From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50294 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Om5l6-0007E0-Dc
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 10:06:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Om5l1-0001ri-0z
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 10:06:20 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:41079)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Om5l0-0001rd-Tr
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 10:06:14 -0400
Received: by ywa6 with SMTP id 6so697804ywa.4
	for <qemu-devel@nongnu.org>; Thu, 19 Aug 2010 07:06:14 -0700 (PDT)
Message-ID: <4C6D3A33.1090002@codemonkey.ws>
Date: Thu, 19 Aug 2010 09:05:39 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/9] configure: add logging
References: <1282221625-29501-1-git-send-email-kraxel@redhat.com>
	<1282221625-29501-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1282221625-29501-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 08/19/2010 07:40 AM, Gerd Hoffmann wrote:
> Write compile commands and messages to config.log.
> Useful for debugging configure.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>    

Indeed.

Acked-by: Anthony Liguori <aliguori@us.ibm.com>

Given the large nature of spice, I suggest that you setup a subtree for 
it and do a pull request when the first round is ready.

Regards,

Anthony Liguori

> ---
>   configure |    7 +++++--
>   1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index a20371c..13d8be0 100755
> --- a/configure
> +++ b/configure
> @@ -16,15 +16,18 @@ TMPO="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.o"
>   TMPE="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.exe"
>
>   trap "rm -f $TMPC $TMPO $TMPE ; exit" EXIT INT QUIT TERM
> +rm -f config.log
>
>   compile_object() {
> -  $cc $QEMU_CFLAGS -c -o $TMPO $TMPC>  /dev/null 2>  /dev/null
> +  echo $cc $QEMU_CFLAGS -c -o $TMPO $TMPC>>  config.log
> +  $cc $QEMU_CFLAGS -c -o $TMPO $TMPC>>  config.log 2>&1
>   }
>
>   compile_prog() {
>     local_cflags="$1"
>     local_ldflags="$2"
> -  $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags>  /dev/null 2>  /dev/null
> +  echo $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags>>  config.log
> +  $cc $QEMU_CFLAGS $local_cflags -o $TMPE $TMPC $LDFLAGS $local_ldflags>>  config.log 2>&1
>   }
>
>   # check whether a command is available to this shell (may be either an
>