qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@web.de>, qemu list <qemu-devel@nongnu.org>,
	Gleb Natapov <gleb@redhat.com>,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix
Date: Thu, 19 Aug 2010 10:19:40 -0500	[thread overview]
Message-ID: <4C6D4B8C.4070501@codemonkey.ws> (raw)
In-Reply-To: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>

On 06/23/2010 09:44 AM, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   qemu-config.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-config.c b/qemu-config.c
> index 95abe61..730ffd9 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
>           },{
>               .name = "clock",
>               .type = QEMU_OPT_STRING,
> -#ifdef TARGET_I386
>           },{
>               .name = "driftfix",
>               .type = QEMU_OPT_STRING,
> -#endif
>           },
>           { /* end if list */ }
>       },
>    

      parent reply	other threads:[~2010-08-19 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 14:44 [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix Amit Shah
2010-06-23 14:50 ` [Qemu-devel] " Paolo Bonzini
2010-06-23 14:50 ` Juan Quintela
2010-06-24 10:02 ` [Qemu-devel] " Jes Sorensen
2010-07-14 13:32 ` Amit Shah
2010-07-27  9:48   ` [Qemu-devel] [PING^2] " Paolo Bonzini
2010-08-06 11:12 ` [Qemu-devel] " Daniel P. Berrange
2010-08-06 20:40   ` Amit Shah
2010-08-09 13:29     ` Anthony Liguori
2010-08-19 15:19 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6D4B8C.4070501@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=amit.shah@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).