From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37039 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Om78E-0008EP-BL
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Om78C-0008Hi-Up
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:18 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:44200)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Om78C-0008Hc-Lx
	for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:16 -0400
Received: by gwb11 with SMTP id 11so818362gwb.4
	for <qemu-devel@nongnu.org>; Thu, 19 Aug 2010 08:34:16 -0700 (PDT)
Message-ID: <4C6D4EF4.8020602@codemonkey.ws>
Date: Thu, 19 Aug 2010 10:34:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 8/9] spice: simple display
References: <1282221625-29501-1-git-send-email-kraxel@redhat.com>
	<1282221625-29501-9-git-send-email-kraxel@redhat.com>
	<4C6D4221.8080504@codemonkey.ws>
	<alpine.LNX.2.00.1008191922390.5362@linmac>
In-Reply-To: <alpine.LNX.2.00.1008191922390.5362@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On 08/19/2010 10:23 AM, malc wrote:
>
>>> +
>>> +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy, SimpleSpiceUpdate
>>> *update)
>>> +{
>>> +    qemu_free(update->bitmap);
>>> +    qemu_free(update);
>>> +}
>>> +
>>> +void qemu_spice_create_host_memslot(SimpleSpiceDisplay *ssd)
>>> +{
>>> +    QXLDevMemSlot memslot;
>>> +
>>> +    if (debug)
>>> +        fprintf(stderr, "%s:\n", __FUNCTION__);
>>>
>>>        
>> a dprintf() would better fit qemu's style.
>>      
> A dprintf is a POSIX function.
>    

Apparently a recent POSIX function...

Preferred alternatives?  I really dislike all caps macros.

Regards,

Anthony Liguori