From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37131 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Om78p-0000KR-KG for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Om78o-0008N1-En for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23008) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om78o-0008Mt-73 for qemu-devel@nongnu.org; Thu, 19 Aug 2010 11:34:54 -0400 Message-ID: <4C6D4F19.3070609@redhat.com> Date: Thu, 19 Aug 2010 17:34:49 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/9] add pflib: PixelFormat conversion library. References: <1282221625-29501-1-git-send-email-kraxel@redhat.com> <1282221625-29501-2-git-send-email-kraxel@redhat.com> <4C6D39F1.7010408@codemonkey.ws> In-Reply-To: <4C6D39F1.7010408@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 08/19/10 16:04, Anthony Liguori wrote: > On 08/19/2010 07:40 AM, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann > > This code is more or less stand alone so it's a good candidate for > having some in-tree unit tests. > > I can provide some examples of how it should be done if you like, but > just something that lives in tests/ that exercises the functionality and > can be run under valgrind to verify that we aren't leaking memory. Yea, some example would be great. Commented tests/example.c maybe? thanks, Gerd