From: Jan Kiszka <jan.kiszka@web.de>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] hw/musicpal: Set loader start address
Date: Thu, 19 Aug 2010 18:50:48 +0200 [thread overview]
Message-ID: <4C6D60E8.2040003@web.de> (raw)
In-Reply-To: <1281365527-7229-1-git-send-email-weil@mail.berlios.de>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Stefan Weil wrote:
> Start address 0x0 did not work with a linux kernel.
Never tried this, always loaded u-boot this way. But that one is fine
with the shifted offset, so:
Acked-by: Jan Kiszka <jan.kiszka@web.de>
Out of curiosity: Which kernel are you booting on this platform, the
Marvel BSP kernel shipped by Freecom?
JAn
>
> Cc: Jan Kiszka <jan.kiszka@web.de>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/musicpal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 33180a2..dc6bc21 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1470,7 +1470,7 @@ static SysBusDeviceInfo musicpal_key_info = {
> };
>
> static struct arm_boot_info musicpal_binfo = {
> - .loader_start = 0x0,
> + .loader_start = MP_SRAM_BASE,
> .board_id = 0x20e,
> };
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2010-08-19 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 14:52 [Qemu-devel] [PATCH] hw/musicpal: Set loader start address Stefan Weil
2010-08-19 16:50 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6D60E8.2040003@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).