From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34020 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OmPiZ-000072-05
	for qemu-devel@nongnu.org; Fri, 20 Aug 2010 07:25:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OmOww-0006hf-Ll
	for qemu-devel@nongnu.org; Fri, 20 Aug 2010 06:35:54 -0400
Received: from david.siemens.de ([192.35.17.14]:21182)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@siemens.com>) id 1OmOww-0006h8-DL
	for qemu-devel@nongnu.org; Fri, 20 Aug 2010 06:35:50 -0400
Message-ID: <4C6E5A70.8000606@siemens.com>
Date: Fri, 20 Aug 2010 12:35:28 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <AANLkTikId-kuGpCNvhLklY5SiTJhpOKaCDzpNvLT0Wd4@mail.gmail.com>	<4C6D86F9.3010602@codemonkey.ws>	<AANLkTimGH9WAgFs5VuvdhFxjPnTjpcKXgkEf7cOSk5JV@mail.gmail.com>
	<4C6D98E7.9020109@codemonkey.ws>
In-Reply-To: <4C6D98E7.9020109@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 0/7] APIC/IOAPIC cleanup
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, "Liu >> \"Liu,
	Jinsong\"" <jinsong.liu@intel.com>, Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

Anthony Liguori wrote:
> On 08/19/2010 03:09 PM, Blue Swirl wrote:
>> On Thu, Aug 19, 2010 at 7:33 PM, Anthony
>> Liguori<anthony@codemonkey.ws>  wrote:
>>   
>>> On 06/12/2010 04:14 PM, Blue Swirl wrote:
>>>     
>>>> Clean up APIC and IOAPIC. Convert both devices to qdev.
>>>>
>>>> v1->v2:
>>>> Remove apic.h reorganization.
>>>> Add IOAPIC and APIC qdev conversions.
>>>> Use CPUState also in 5/7. However on 6/7 we have to again use void *
>>>> because of VMState limitations. VMState gurus, please comment.
>>>>
>>>>        
>>> I'm late to the game here, but I'm not sure converting the APIC to qdev
>>> makes a lot of sense conceptually.
>>>      
>> Very late. I think it makes tons of sense, for example with 'info
>> qtree' you now see most of the QEMU devices. The CPUs are still
>> missing.
>>    
> 
> Should CPUs appear in the QEMU device tree?

Yes, we want to browse/display the whole virtual machine (one day). QMP
could then avoid an equivalent of "info registers" and expose the CPU
state via dumping qdev devices.

And note the the APIC was not part of the CPU core before Pentiums, and
we support that model as well.

Therefore, I like the idea of having a hotplug-capable (where
appropriate) CPU bus.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux