From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57736 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmQBW-00058W-Mk for qemu-devel@nongnu.org; Fri, 20 Aug 2010 07:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmQBV-00043E-Er for qemu-devel@nongnu.org; Fri, 20 Aug 2010 07:54:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57400) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmQBV-000435-73 for qemu-devel@nongnu.org; Fri, 20 Aug 2010 07:54:57 -0400 Message-ID: <4C6E6D0D.4090504@redhat.com> Date: Fri, 20 Aug 2010 13:54:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 5/9] spice: core bits References: <1282221625-29501-1-git-send-email-kraxel@redhat.com> <1282221625-29501-6-git-send-email-kraxel@redhat.com> <4C6D3D6E.5080003@codemonkey.ws> In-Reply-To: <4C6D3D6E.5080003@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org >> +#ifdef CONFIG_SPICE > > Now's probably a good time to make vm_config_groups a list that can be > dynamically added to so that you can register the option group from > within spice.c. > > This would require a new qemu_opts_parse() that took a name of an > QemuOptsList instead of the pointer to it but then you can return > failure if spice is unsupported. Ah, you want me fix virtfs too ;) Patches are on the list. Well, at least a start. For further cleanups we'll need some more *_init() magic for the non-devices stuff. cheers, Gerd