From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53104 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmQvu-00066c-QH for qemu-devel@nongnu.org; Fri, 20 Aug 2010 08:42:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmQvt-0002fV-Mo for qemu-devel@nongnu.org; Fri, 20 Aug 2010 08:42:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11942) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmQvt-0002fL-F6 for qemu-devel@nongnu.org; Fri, 20 Aug 2010 08:42:53 -0400 Message-ID: <4C6E7849.1010906@redhat.com> Date: Fri, 20 Aug 2010 14:42:49 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 7/9] spice: add mouse References: <1282221625-29501-1-git-send-email-kraxel@redhat.com> <1282221625-29501-8-git-send-email-kraxel@redhat.com> <4C6D3EEA.4020201@codemonkey.ws> In-Reply-To: <4C6D3EEA.4020201@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Hi, >> +static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int >> dz, >> + uint32_t buttons_state) >> +{ >> + kbd_mouse_event(dx, dy, dz, buttons_state); > > dz is an odd interface. We use it to represent additional buttons which > really makes no sense. If you still can, I'd suggest moving dz into > buttons_state. Again this is libspice interface (and I think also wire protocol), so I can't change it. I can convert dz into some button_mask bits before calling kbd_mouse_event, but looking at the vnc code it seems qemu expects the mouse wheel events being passed via dz not button_state. > Previous comment still applies though, you should explicitly convert the > button_states from QEMU format to Spice format to future proof. Ok. cheers, Gerd