From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37021 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmSCP-0001tk-8f for qemu-devel@nongnu.org; Fri, 20 Aug 2010 10:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmSCM-00077b-TH for qemu-devel@nongnu.org; Fri, 20 Aug 2010 10:03:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31421) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmSCM-00077R-LF for qemu-devel@nongnu.org; Fri, 20 Aug 2010 10:03:58 -0400 Message-ID: <4C6E8B49.3040601@redhat.com> Date: Fri, 20 Aug 2010 16:03:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 7/9] spice: add mouse References: <1282221625-29501-1-git-send-email-kraxel@redhat.com> <1282221625-29501-8-git-send-email-kraxel@redhat.com> <4C6D3EEA.4020201@codemonkey.ws> <4C6E7849.1010906@redhat.com> <4C6E80E8.6040202@codemonkey.ws> In-Reply-To: <4C6E80E8.6040202@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Hi, >> Again this is libspice interface (and I think also wire protocol), so >> I can't change it. I can convert dz into some button_mask bits before >> calling kbd_mouse_event, but looking at the vnc code it seems qemu >> expects the mouse wheel events being passed via dz not button_state. > > That's unfortunate but understood. Is Spice considered a stable API/wire > protocol at this point? Yes. There are version numbers though, so we can add new messages and use them in case both server and client are new enough. Unfortunaly this makes the keyboard f*ckup only slightly less messy as we'll have to support both old+new way for compatibility reasons. Oh well. cheers, Gerd