From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40896 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnFTj-0004Kj-Ow
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:41:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnFTi-0006rg-Hl
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:41:11 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:65110)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnFTi-0006rU-Ex
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:41:10 -0400
Received: by yxn35 with SMTP id 35so2025815yxn.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 11:41:09 -0700 (PDT)
Message-ID: <4C716F43.8070805@codemonkey.ws>
Date: Sun, 22 Aug 2010 13:41:07 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>
	<alpine.LNX.2.00.1008122251300.1975@linmac>
	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>
	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>
	<4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws>
	<m3vd75flas.fsf@blackfin.pond.sub.org>
	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>
	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>
	<m3eidsxpdo.fsf@blackfin.pond.sub.org>
	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>
	<m3bp8wp30w.fsf@blackfin.pond.sub.org>
	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>
	<4C71550F.6080602@redhat.com>
In-Reply-To: <4C71550F.6080602@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/22/2010 11:49 AM, Jes Sorensen wrote:
>>> While wasting time for historical reasons is certainly better than
>>> wasting time for the heck of it, it's arguably worse than stopping the
>>> waste.
>>>        
>> But how would you do that? Drop the CODING_STYLE (and accept
>> anything)? Switch to a new CODING_STYLE that is widely appreciated and
>> so all bikeshedding will cease? Enforce current style?
>>      
> I would suggest we either clean up the existing rule, or switch to the
> Linux kernel style, with the explicit exemption that existing code can
> keep the 4-char indentation, unless the whole file is converted. I'd
> like to avoid a total reformatting of the codebase, but we could look at
> it on a file by file base if it becomes relevant.
>    

Why is this even still being discussed?  What problem are people 
actually trying to solve?

Can someone point to a bug in QEMU that's been caused because of 
CODING_STYLE or the fact that some patches don't adhere to it?

I don't see a problem with the way things are today.

Regards,

Anthony Liguori

> Regards,
> Jes
>