From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37256 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnGDo-0007QN-6l
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:28:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnGDn-00036D-7D
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:28:48 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:44657)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnGDn-000367-3G
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:28:47 -0400
Received: by gyh4 with SMTP id 4so2043775gyh.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 12:28:46 -0700 (PDT)
Message-ID: <4C717A6C.9080805@codemonkey.ws>
Date: Sun, 22 Aug 2010 14:28:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>
	<alpine.LNX.2.00.1008122251300.1975@linmac>
	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>
	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>
	<4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws>
	<m3vd75flas.fsf@blackfin.pond.sub.org>
	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>
	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>
	<m3eidsxpdo.fsf@blackfin.pond.sub.org>
	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>
	<m3bp8wp30w.fsf@blackfin.pond.sub.org>
	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>
	<4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws>
	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>
In-Reply-To: <AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/22/2010 01:56 PM, Blue Swirl wrote:
>> Why is this even still being discussed?  What problem are people actually
>> trying to solve?
>>
>> Can someone point to a bug in QEMU that's been caused because of
>> CODING_STYLE or the fact that some patches don't adhere to it?
>>      
> 7b1df88f284f462ecb236931ad863a815f243195
>    

That's a hell of a bug :-)

>> I don't see a problem with the way things are today.
>>      
> There is the problem that some patch submitters are reminded of
> CODING_STYLE while others aren't.

I still think we spend far too much time discussing this on list.  While 
I stand corrected that we've ever had a bug because of this, I have a 
hard time believing this is anywhere in the top 10 list of issues that 
we have.

Regards,

Anthony Liguori

>   Some don't need to be reminded but
> they are not part of the problem.
>