From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51204 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnGlz-000887-Pz
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:04:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnGly-00074T-I3
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:04:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8268)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnGly-00074J-Bu
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:04:06 -0400
Message-ID: <4C7182AA.6010707@redhat.com>
Date: Sun, 22 Aug 2010 23:03:54 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<m3bp8wp30w.fsf@blackfin.pond.sub.org>	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>	<4C71550F.6080602@redhat.com>	<AANLkTikfONmRe43b-gxy33eaRxiQV9wZ0eR0SM8pEAEc@mail.gmail.com>	<alpine.LNX.2.00.1008222236030.3965@linmac>
	<4C716FB3.2090505@codemonkey.ws>
In-Reply-To: <4C716FB3.2090505@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>

  On 08/22/2010 09:42 PM, Anthony Liguori wrote:
>
> I'm strongly opposed to any reformatting of the tree.

I strongly second this statement.

>
> All it does is break git blame which makes debugging harder without 
> offering any real benefits.
>

Even worse, it makes backporting patches much harder.

Sometimes we have to refactor the code to introduce new features or fix 
deep deficiencies.  Let's not do it just to change the code style.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.