From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34034 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnGyv-00022g-OF
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:17:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnGyr-0008LV-Ls
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:17:29 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:58544)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnGyr-0008LN-H2
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:17:25 -0400
Received: by gwb11 with SMTP id 11so2049265gwb.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 13:17:25 -0700 (PDT)
Message-ID: <4C7185D3.5020506@codemonkey.ws>
Date: Sun, 22 Aug 2010 15:17:23 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>
	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<m3bp8wp30w.fsf@blackfin.pond.sub.org>	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>	<4C71550F.6080602@redhat.com>
	<4C716F43.8070805@codemonkey.ws>
	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>
	<4C71840B.7040409@redhat.com>
In-Reply-To: <4C71840B.7040409@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 08/22/2010 03:09 PM, Avi Kivity wrote:
>  On 08/22/2010 09:56 PM, Blue Swirl wrote:
>>
>>> Can someone point to a bug in QEMU that's been caused because of
>>> CODING_STYLE or the fact that some patches don't adhere to it?
>> 7b1df88f284f462ecb236931ad863a815f243195
>
> How was this bug caused by CODING_STYLE?  In fact, if CODING_STYLE was 
> applied correctly then this bug would stand out much more:
>
>     if (...) {
>         /* .... */;
>     }
>         return;

"or the fact that some patches don't adhere to it".  If CODING_STYLE was 
enforced at commit time, this bug would not have happened most likely.

But it's such an odd case that I'd say it's just the exception that 
proves the rule that a loose CODING_STYLE isn't significantly impacting 
overall quality.

I also don't believe that it's creating distress in contributors.  I 
believe timely patch review/commit is probably a more important issue 
for contributors than whether some people get by without CODING_STYLE 
being strictly enforced.

Regards,

Anthony Liguori

>
> or be completely eliminated:
>
>     if (...) {
>         /* .... */;
>         return;
>     }
>
>