From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57692 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnHH3-0003fi-U7 for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnHGz-0001cM-1V for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:36:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39737) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnHGy-0001cF-QO for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:36:09 -0400 Message-ID: <4C718A33.60100@redhat.com> Date: Sun, 22 Aug 2010 23:36:03 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C6A94D0.2090201@redhat.com> <4C6D3260.8010103@redhat.com> <4C71856B.2050109@redhat.com> <4C7186A6.7030107@redhat.com> In-Reply-To: <4C7186A6.7030107@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Blue Swirl , Miguel Di Ciurcio Filho , qemu-devel On 08/22/2010 11:20 PM, Jes Sorensen wrote: > >> I happen to like the single line braces rule. That is, I don't like how >> the code looks (I dislike punctuation generally), but I like the >> consistency and I like how patches that add or remove a line are easy to >> read. >> >> My preference would be: new code has to adhere to the new style. > Agreed, once we pick something, make the new stuff stick to that. The > main issue is when you make mods to a file that is using a different > style. It's not ideal that you add one line of the new style and the > rest is the old way. I happen not to care too much but that's a personal thing I guess. >> Perhaps we can have a bot subscribed to the list issue auto-reviews if >> things are incorrect. > That might work. Anyone for a Google Weekend of Code? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.