From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39839 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnHKO-0005LH-3B for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:39:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnHKN-0001vS-5z for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:39:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35145) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnHKM-0001v3-RQ for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:39:39 -0400 Message-ID: <4C718AF7.6000403@redhat.com> Date: Sun, 22 Aug 2010 23:39:19 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws> <4C717A6C.9080805@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Jes Sorensen , Markus Armbruster , qemu-devel , Blue Swirl , Miguel Di Ciurcio Filho On 08/22/2010 10:44 PM, malc wrote: > >> There is the problem that some patch submitters are reminded of >> CODING_STYLE while others aren't. Some don't need to be reminded but >> they are not part of the problem. > And to this i fully subscribe. I agree. From my Linux experience, I started out whining about each and every coding style violation. To my own great self-annoyance. After a while all contributors adjusted and now this is quite rare. Enforce the coding style with an iron hand, and pretty soon you won't have to. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.