From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43318 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnHMZ-0006K2-Gy
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:41:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnHMY-00028J-GY
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:41:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54279)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnHMY-00028E-AH
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:41:54 -0400
Message-ID: <4C718B8B.6070406@redhat.com>
Date: Sun, 22 Aug 2010 23:41:47 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<m3bp8wp30w.fsf@blackfin.pond.sub.org>	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>	<4C71550F.6080602@redhat.com>	<4C716F43.8070805@codemonkey.ws>	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>	<4C71840B.7040409@redhat.com>
	<4C7185D3.5020506@codemonkey.ws>
In-Reply-To: <4C7185D3.5020506@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

  On 08/22/2010 11:17 PM, Anthony Liguori wrote:
> On 08/22/2010 03:09 PM, Avi Kivity wrote:
>>  On 08/22/2010 09:56 PM, Blue Swirl wrote:
>>>
>>>> Can someone point to a bug in QEMU that's been caused because of
>>>> CODING_STYLE or the fact that some patches don't adhere to it?
>>> 7b1df88f284f462ecb236931ad863a815f243195
>>
>> How was this bug caused by CODING_STYLE?  In fact, if CODING_STYLE 
>> was applied correctly then this bug would stand out much more:
>>
>>     if (...) {
>>         /* .... */;
>>     }
>>         return;
>
> "or the fact that some patches don't adhere to it".  If CODING_STYLE 
> was enforced at commit time, this bug would not have happened most 
> likely.

Ah, yes.

>
> But it's such an odd case that I'd say it's just the exception that 
> proves the rule that a loose CODING_STYLE isn't significantly 
> impacting overall quality.

I agree.  IMO a consistent coding style is mainly an aid to the reader, 
the brain has one less thing to disentangle.

> I also don't believe that it's creating distress in contributors.  I 
> believe timely patch review/commit is probably a more important issue 
> for contributors than whether some people get by without CODING_STYLE 
> being strictly enforced.

Definitely.  Especially as people can adjust to CODING_STYLE.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.