From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43479 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnHOA-00076U-Cy
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:43:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnHO9-0002GL-94
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:43:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21487)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnHO9-0002GG-0g
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:43:33 -0400
Message-ID: <4C718BEF.9000601@redhat.com>
Date: Sun, 22 Aug 2010 23:43:27 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>
	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<4C715317.5020007@redhat.com>
	<4C7184B7.1090608@redhat.com>
	<AANLkTin4toC36nYW3T5ryOspN81Zia1FdWUJnkuzESyd@mail.gmail.com>
In-Reply-To: <AANLkTin4toC36nYW3T5ryOspN81Zia1FdWUJnkuzESyd@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

  On 08/22/2010 11:16 PM, Blue Swirl wrote:
>
>> scripts/Lindent is just a wrapper around indent(1).  We don't need to come
>> up with new tools, just come up with the right switches to indent(1).
> More importantly, we want checkpatch.pl.

That's a bit too obnoxious in my opinion.  I think the main thing is to 
warn about braces and tabs, everything else is either rare or stands out 
better.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.