From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40101 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnI76-0006Cc-F6
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:30:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnI75-0006LE-D5
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:30:00 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:38034)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnI75-0006L8-6r
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:29:59 -0400
Received: by ywa6 with SMTP id 6so1994428ywa.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 14:29:58 -0700 (PDT)
Message-ID: <4C7196D4.4030600@codemonkey.ws>
Date: Sun, 22 Aug 2010 16:29:56 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] target-i386: svm: Fix MSRPM check
References: <20100815135832.GA5355@os.inf.tu-dresden.de>
In-Reply-To: <20100815135832.GA5355@os.inf.tu-dresden.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org

On 08/15/2010 08:58 AM, Adam Lackorzynski wrote:
> Correct the calculation of the offset in the msrpm
> for the MSR range 0 - 0x1fff.
>
> Signed-off-by: Adam Lackorzynski<adam@os.inf.tu-dresden.de>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   target-i386/op_helper.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index c50e818..ec6b3e9 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -5237,7 +5237,7 @@ void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
>               switch((uint32_t)ECX) {
>               case 0 ... 0x1fff:
>                   t0 = (ECX * 2) % 8;
> -                t1 = ECX / 8;
> +                t1 = (ECX * 2) / 8;
>                   break;
>               case 0xc0000000 ... 0xc0001fff:
>                   t0 = (8192 + ECX - 0xc0000000) * 2;
>