From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49519 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnIFU-0003QA-4g
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:38:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnIFT-00075X-10
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:38:39 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:57746)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnIFS-00075T-Ts
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 17:38:38 -0400
Received: by yxn35 with SMTP id 35so2054833yxn.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 14:38:38 -0700 (PDT)
Message-ID: <4C7198DC.9020501@codemonkey.ws>
Date: Sun, 22 Aug 2010 16:38:36 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 01/14] trace: Add trace-events file for
	declaring trace events
References: <1281609395-17621-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1281609395-17621-2-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1281609395-17621-2-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Julien Desfossez <ju@klipix.org>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
> +linetoh_nop()
> +{
> +    local name args
> +    name=$(get_name "$1")
> +    args=$(get_args "$1")
> +
> +    # Define an empty function for the trace event
> +    cat<<EOF
> +static inline void trace_$name($args)
> +{
> +}
>    

This seems like it can potentially create a single header that ends up 
needed to know about every type of structure QEMU implements, no?  If 
so, this would be challenging for improving modularity.

Or would we restrict trace points to not allow passing of anything but 
void *s?

Regards,

Anthony Liguori