From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34402 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnUs6-0001fu-IV for qemu-devel@nongnu.org; Mon, 23 Aug 2010 07:07:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnUs5-0002lG-F5 for qemu-devel@nongnu.org; Mon, 23 Aug 2010 07:07:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60446) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnUs5-0002lA-6c for qemu-devel@nongnu.org; Mon, 23 Aug 2010 07:07:21 -0400 Message-ID: <4C72565F.7030207@redhat.com> Date: Mon, 23 Aug 2010 14:07:11 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C715317.5020007@redhat.com> <4C7184B7.1090608@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Blue Swirl , Jes Sorensen , Miguel Di Ciurcio Filho , qemu-devel On 08/23/2010 02:01 PM, Markus Armbruster wrote: > Avi Kivity writes: > >> On 08/22/2010 07:40 PM, Jes Sorensen wrote: >>> I totally agree with Markus >>> that it seems like wasted effort to come up with new tools and having to >>> maintain them when there are good ones out there like the ones from the >>> Linux kernel. >>> >> scripts/Lindent is just a wrapper around indent(1). We don't need to >> come up with new tools, just come up with the right switches to >> indent(1). > How can indent help effectively with policing the formatting of new > code, in the form of patches, without touching the old code? It can't. We need something like checkpatch (but not checkpatch itself, that's much too whiny). -- error compiling committee.c: too many arguments to function