From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52252 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnW1Z-0000fP-MR for qemu-devel@nongnu.org; Mon, 23 Aug 2010 08:21:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnW1Y-0006Ll-Az for qemu-devel@nongnu.org; Mon, 23 Aug 2010 08:21:13 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:34150) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnW1Y-0006Le-7X for qemu-devel@nongnu.org; Mon, 23 Aug 2010 08:21:12 -0400 Received: by ywa6 with SMTP id 6so2172058ywa.4 for ; Mon, 23 Aug 2010 05:21:11 -0700 (PDT) Message-ID: <4C7267B4.3060705@codemonkey.ws> Date: Mon, 23 Aug 2010 07:21:08 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices References: <20100803161914.15514.59304.stgit@localhost6.localdomain6> <4C7262DC.3040001@redhat.com> In-Reply-To: <4C7262DC.3040001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Alex Williamson , glommer@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On 08/23/2010 07:00 AM, Avi Kivity wrote: > Off-topic, but what's the reason for dev->hotplugged's existence? A > device is either plugged or not, it is either hotpluggable or not, but > is there a way to tell, from looking at a plugged device, whether it > has been hotplugged in the past? > > AFAICT it is redundant state and should be removed. I've got that in my qdev tree. http://repo.or.cz/w/qemu/aliguori.git/commit/672720c5c0315d2a5b43f58fd75822cc4a390ae9 Regards, Anthony Liguori