From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52725 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnXcO-0003or-MK for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnXcN-0005YZ-Ek for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:03:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26658) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnXcN-0005YS-8Z for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:03:19 -0400 Message-ID: <4C727F9E.2080203@redhat.com> Date: Mon, 23 Aug 2010 17:03:10 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws> <4C717A6C.9080805@codemonkey.ws> <4C718AF7.6000403@redhat.com> <4C727DC5.9010805@redhat.com> In-Reply-To: <4C727DC5.9010805@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Markus Armbruster , qemu-devel , Blue Swirl , Miguel Di Ciurcio Filho On 08/23/2010 04:55 PM, Jes Sorensen wrote: > > Well with the inconsistency we have now, what is the right iron fist to > apply? Demand the code is consistent with the file you edit or that it's > consistent with whats in CODING_STYLE, even if it means that what you > apply is completely different to the rest of the file? > > That is the part I think needs to be decided upon in all of this. Patch lines that start with ^\+ should be consistent with CODING_STYLE. The maintainers may allow exceptions in certain cases, but contributors shouldn't expect this. Use common sense where available. -- error compiling committee.c: too many arguments to function