From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51013 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnXpP-0001cd-QD
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:16:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <john@john-cooper.org>) id 1OnXpO-0007cM-J3
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:16:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5131)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <john@john-cooper.org>) id 1OnXpO-0007ar-Co
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:16:46 -0400
Message-ID: <4C727FE1.908@john-cooper.org>
Date: Mon, 23 Aug 2010 10:04:17 -0400
From: john cooper <john@john-cooper.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<alpine.LNX.2.00.1008122251300.1975@linmac>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>
	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<4C715317.5020007@redhat.com>	<AANLkTi=_1pe53y=ZWYo-PVVzFcaYqm-2U2tpY8gg-YTD@mail.gmail.com>	<alpine.LNX.2.00.1008222238010.3965@linmac>
	<4C722E00.80405@redhat.com>
In-Reply-To: <4C722E00.80405@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: john cooper <john.cooper@third-harmonic.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>

Jes Sorensen wrote:
> On 08/22/10 20:39, malc wrote:
>   
>> Disregarding my own stance on the braces, braces around single statement
>> is actually helpful w.r.t. debugging imaging trying to set a break point
>> on said singlesttement, plain impossible in following case:
>>
>> if (a) b;
>>     
>
> Oh there is no talk about suggesting we force things onto a single line.
> Putting if(foo) bar(); on the same line is just plain wrong, what I
> referred to was this:
>
>     if (foo)
>         bar();
>
> vs
>     if (foo) {
>         bar();
>     }
>
> If it is part of a multi-block if()/else block yes it's good for
> consistency, if it is a one off in the code, it doesn't add any value
> IMHO, it is a loss because it wastes space for no reason.
>   
About the only benefit I've found for that added syntactic sugar
is simplifying debug somewhat as you aren't falling in/out of the
grammar optimization.

But from a maintainability perspective, where possible I avoid
formatting which dilutes the information content in a code window.
It negatively impacts readability IMHO.

-john