From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48750 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnXoA-0000iR-J7
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnXo9-0007Q4-0S
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:15:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54813)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OnXo8-0007Pg-Pw
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 10:15:28 -0400
Message-ID: <4C728278.5050500@redhat.com>
Date: Mon, 23 Aug 2010 17:15:20 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>	<4C6A4291.1020105@redhat.com>
	<4C6A8CD8.2080701@codemonkey.ws>	<m3vd75flas.fsf@blackfin.pond.sub.org>	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>	<m3eidsxpdo.fsf@blackfin.pond.sub.org>	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>	<m3bp8wp30w.fsf@blackfin.pond.sub.org>	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>	<4C71550F.6080602@redhat.com>
	<4C716F43.8070805@codemonkey.ws>	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>	<4C717A6C.9080805@codemonkey.ws>
	<alpine.LNX.2.00.1008222341190.4325@linmac>
	<4C718AF7.6000403@redhat.com> <4C727DC5.9010805@redhat.com>
	<4C727F9E.2080203@redhat.com> <4C72808B.4090500@redhat.com>
In-Reply-To: <4C72808B.4090500@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>

  On 08/23/2010 05:07 PM, Jes Sorensen wrote:
> On 08/23/10 16:03, Avi Kivity wrote:
>>   On 08/23/2010 04:55 PM, Jes Sorensen wrote:
>>> Well with the inconsistency we have now, what is the right iron fist to
>>> apply? Demand the code is consistent with the file you edit or that it's
>>> consistent with whats in CODING_STYLE, even if it means that what you
>>> apply is completely different to the rest of the file?
>>>
>>> That is the part I think needs to be decided upon in all of this.
>> Patch lines that start with ^\+ should be consistent with CODING_STYLE.
>> The maintainers may allow exceptions in certain cases, but contributors
>> shouldn't expect this.  Use common sense where available.
>>
> Right, in my book common sense is to be consistent with the file I am
> editing, as long as the file isn't in gross violation of CODING_STYLE,
> but maybe my sense just isn't that good.

I'd have said the opposite - if the file _is_ in gross violation, mixing 
styles would make it unreadable.  If it's just slightly different then 
using C_S would improve it incrementally.

-- 
error compiling committee.c: too many arguments to function