From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60815 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Onb7b-0007hB-Oh for qemu-devel@nongnu.org; Mon, 23 Aug 2010 13:47:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Onb7a-0000h6-9b for qemu-devel@nongnu.org; Mon, 23 Aug 2010 13:47:47 -0400 Received: from mail-iw0-f173.google.com ([209.85.214.173]:55933) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Onb7a-0000gz-6i for qemu-devel@nongnu.org; Mon, 23 Aug 2010 13:47:46 -0400 Received: by iwn38 with SMTP id 38so2065486iwn.4 for ; Mon, 23 Aug 2010 10:47:45 -0700 (PDT) Message-ID: <4C72B43D.5010607@codemonkey.ws> Date: Mon, 23 Aug 2010 12:47:41 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 0/7] APIC/IOAPIC cleanup References: <4C6D86F9.3010602@codemonkey.ws> <4C6D98E7.9020109@codemonkey.ws> <4C6DA75D.40303@codemonkey.ws> <4C6ECBB7.7060608@codemonkey.ws> <4C718865.7010807@redhat.com> <4C719080.4030202@codemonkey.ws> <4C720B1F.3030206@redhat.com> <4C727646.3040903@codemonkey.ws> <4C727ACC.7080501@redhat.com> <4C727C43.2040704@codemonkey.ws> <4C727EF5.6060402@redhat.com> <4C72851E.50405@codemonkey.ws> <4C72869A.3030302@redhat.com> <4C728A12.2090006@codemonkey.ws> <4C729C32.5040803@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Blue Swirl , "Liu @mail.corp.redhat.com>> \"Liu, Jinsong\"" , qemu-devel , Avi Kivity , Paul Brook On 08/23/2010 12:36 PM, Markus Armbruster wrote: > Anthony Liguori writes: > > >> On 08/23/2010 10:10 AM, Markus Armbruster wrote: >> >>> You lost me. A few messages upthread. >>> >>> What's the *practical* problem again? >>> >>> >> CPU hotplug adds a local APIC to Sysbus but Sysbus does not allow hot plug. >> >> I believe the right short term way to fix this is to take the local >> APIC off of Sysbus. The right long term fix is to not make the local >> APIC a qdev device and instead fold it into CPUX86State. >> > Treating the LAPIC as a part of the CPU makes sense to me. I can't see, > however, how all the OO-talk in this thread is related to that, and I > can't connect the OO-talk to a practical problem. Do I miss anything > important? > It's abstract talk about what the qdev object module includes, what it doesn't include, and what the interfaces are. It started because I claimed that the lapic doesn't fit the qdev object module and Avi disagrees. Regards, Anthony Liguori