From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50581 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnfqU-0001SC-CP
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:50:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnfqS-0005m0-NR
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:50:26 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:64666)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnfqS-0005lq-Kb
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 18:50:24 -0400
Received: by iwn38 with SMTP id 38so2257744iwn.4
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 15:50:23 -0700 (PDT)
Message-ID: <4C72FB2C.9000404@codemonkey.ws>
Date: Mon, 23 Aug 2010 17:50:20 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
References: <1282600951-30803-1-git-send-email-agraf@suse.de>	<1282600951-30803-5-git-send-email-agraf@suse.de>	<4C72F46D.5040606@codemonkey.ws>	<F481E293-2570-47BF-8575-9D78E83EA573@suse.de>
	<B5AAA57B-BD29-4F78-AE4C-4D63B41B539C@suse.de>
In-Reply-To: <B5AAA57B-BD29-4F78-AE4C-4D63B41B539C@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel List <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Markus Armbruster <armbru@redhat.com>

On 08/23/2010 05:45 PM, Alexander Graf wrote:
>> Device_add already works with this set and only required minor changes the s390 specific code. So that part was pretty slick :). The part that didn't work was the drive_add one.
>>
>> What is blockdev_add supposed to be? drive_add without IF_SCSI?

drive_add without if= and without the PCI-isms.

>> To be a bit more precise on how things work with this set:
>>
>> (qemu) drive_add 0 id=my_disk,if=none,file=/dev/null
>> OK
>>      

In theory, something like:

(qemu) blockdev_add id=my_disk,file=/dev/null

Regards,

Anthony Liguori

>> (qemu) device_add virtio-blk-s390,drive=my_disk,id=new_disk
>>
>> gives me a working new virtio disk in the VM that's mapped to /dev/null :).
>>
>>
>> Alex
>>