From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59361 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Onrtc-0007J1-Nj for qemu-devel@nongnu.org; Tue, 24 Aug 2010 07:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnrtX-0002a6-4w for qemu-devel@nongnu.org; Tue, 24 Aug 2010 07:42:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64854) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnrtW-0002Zy-UG for qemu-devel@nongnu.org; Tue, 24 Aug 2010 07:42:23 -0400 Message-ID: <4C73B01A.1050908@redhat.com> Date: Tue, 24 Aug 2010 14:42:18 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] Check pci slot number in parse_pci_devfn References: <20100824063307.GA10815@kt> <20100824064927.GB11495@kt> <20100824113521.GA7201@valinux.co.jp> In-Reply-To: <20100824113521.GA7201@valinux.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: Ken CC , qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 08/24/2010 02:35 PM, Isaku Yamahata wrote: > Add Cc: mst@redhat.com. > > MAX_PCI_SLOTS should be in pci.h instead of qdev.h? > And the name should be start with PCI_ prefix for consistency? > > Except that, the patches look okay. > These aren't slots, are they? They are functions. There's a lot of slot/function confusion in qemu. -- error compiling committee.c: too many arguments to function