From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42177 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnyLT-0006SB-TT
	for qemu-devel@nongnu.org; Tue, 24 Aug 2010 14:35:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnyLN-0004Vi-G8
	for qemu-devel@nongnu.org; Tue, 24 Aug 2010 14:35:39 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:38932)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OnyLN-0004VS-BO
	for qemu-devel@nongnu.org; Tue, 24 Aug 2010 14:35:33 -0400
Received: by gya1 with SMTP id 1so164155gya.4
	for <qemu-devel@nongnu.org>; Tue, 24 Aug 2010 11:35:32 -0700 (PDT)
Message-ID: <4C7410F1.4050306@codemonkey.ws>
Date: Tue, 24 Aug 2010 13:35:29 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
References: <1282600951-30803-1-git-send-email-agraf@suse.de>	<1282600951-30803-5-git-send-email-agraf@suse.de>	<20100824093155.GB7376@redhat.com>
	<4C73A2BF.2050605@suse.de>	<20100824105154.GH7376@redhat.com>
	<4C73CBC9.4050602@suse.de> <20100824134446.GM7376@redhat.com>
In-Reply-To: <20100824134446.GM7376@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, Markus Armbruster <armbru@redhat.com>, qemu-devel List <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>

On 08/24/2010 08:44 AM, Daniel P. Berrange wrote:
>
>>> Actually this SCSI example I give above is appending a drive to an existing
>>> bus (scsi0), in slot 1 (scsi-id=1).  To best of my knowledge there is no
>>> remaining use case that requires use of IF_SCSI, IF_IDE, etc. The IF_NONE
>>> approach can cope with all, modulo bugs that appear periodically with code
>>> that mistakenly checks for a particular IF_XXX constant.
>>>
>>> If you wanted to also create a new SCSI bus, before creating the drive on
>>> it, you'd need to run three commands in total:
>>>
>>>    device_add lsi,id=scsi0,bus=pci.0,addr=0x7
>>>    drive_add dummy file=/var/lib/libvirt/images/data.img,if=none,id=drive-scsi0-0-1,format=raw
>>>    device_add scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1
>>>
>>>        
>> Nice - so we can just deprecate if=!none?
>>      
> In theory yes, but its not nice to tell users to switch everything over to
> use if=none, if we're going to deprecate that too in the next release when
> blockdev appears. Might as well just deprecate entire of drive_add/-drive
> at once.
>    

I think what Alex is really asking is can we have 'blockdev_add 
var0=val0,var1=val1[,...]' implemented as 'drive_add dummy 
if=none,var0=val0,var1=val1[,...]'.  I don't know the answer to why that 
isn't possible or desirable.

Regards,

Anthony Liguori

> Regards,
> Daniel
>