From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60210 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OoWMq-0008S9-Sx
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:55:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OoWMp-0007Hl-QT
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:55:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11678)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OoWMp-0007Hd-KP
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:55:19 -0400
Message-ID: <4C760FD2.6010701@redhat.com>
Date: Thu, 26 Aug 2010 08:55:14 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard
References: <1282745970-11506-1-git-send-email-kraxel@redhat.com>
	<1282745970-11506-8-git-send-email-kraxel@redhat.com>
	<4C7574B0.40203@codemonkey.ws>
In-Reply-To: <4C7574B0.40203@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

   Hi,

>> +
>> + qemu_spice_input_init();
>
> Why not pass spice_server to qemu_spice_input_init() and avoid the global?
>

We need the global anyway for the guest devices (not yet in this 
series).  They are created using -device.  Thus the initialization 
functions are not called from spice code and we can't simply pass a 
reference to spice_server.

cheers,
   Gerd