From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58792 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OoWOW-0000pW-9A for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:57:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OoWOV-0007UV-Ak for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:57:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9009) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoWOV-0007UR-4k for qemu-devel@nongnu.org; Thu, 26 Aug 2010 02:57:03 -0400 Message-ID: <4C76103B.5060703@redhat.com> Date: Thu, 26 Aug 2010 08:56:59 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 09/10] spice: simple display References: <1282745970-11506-1-git-send-email-kraxel@redhat.com> <1282745970-11506-10-git-send-email-kraxel@redhat.com> <4C75758C.80501@codemonkey.ws> In-Reply-To: <4C75758C.80501@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org >> +/* called from spice server thread context (via >> interface_release_ressource) */ > > There's still the implicit assumption that the reader understands that > we're not carrying the global mutex here and that we're relying on the > functions used to be re-entrant. I think we need a big scary warning > here otherwise it's just far too easy to break this code. Ok, I'll make it more verbose. cheers, Gerd