From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49998 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OoXT6-0003Fv-Kn for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:05:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OoXT5-0000jG-6b for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:05:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1622) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoXT5-0000iz-0I for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:05:51 -0400 Message-ID: <4C762058.8070301@redhat.com> Date: Thu, 26 Aug 2010 10:05:44 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped References: <8450ea8e785c9049f0b3edddc01650a8c4b9ffe7.1282265244.git.amit.shah@redhat.com> <4C719C7E.6030606@codemonkey.ws> <20100826060513.GF18351@amit-laptop.redhat.com> In-Reply-To: <20100826060513.GF18351@amit-laptop.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: agl@us.ibm.com, qemu list , Juan Quintela On 08/26/2010 08:05 AM, Amit Shah wrote: > This is what I have currently. It would need some timer handling in > the save/load case as well, right? When loading you won't have any pending "info balloon" command, so I think the timer need not be preserved across migration. Also, 5 seconds for a stopped guest is actually a lot, so maybe Amit's original patch or a variant thereof would make sense anyway. Paolo