From: Anthony Liguori <anthony@codemonkey.ws>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard
Date: Thu, 26 Aug 2010 07:55:50 -0500 [thread overview]
Message-ID: <4C766456.3050408@codemonkey.ws> (raw)
In-Reply-To: <4C760FD2.6010701@redhat.com>
On 08/26/2010 01:55 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> +
>>> + qemu_spice_input_init();
>>
>> Why not pass spice_server to qemu_spice_input_init() and avoid the
>> global?
>>
>
> We need the global anyway for the guest devices (not yet in this
> series). They are created using -device. Thus the initialization
> functions are not called from spice code and we can't simply pass a
> reference to spice_server.
Let's avoid it where we can and we'll do what we need to do for the
guest devices.
In general, for the cases that we truly need a global, I'd prefer
getting to it via a function instead of having a non-static variable.
Regards,
Anthony Liguori
>
> cheers,
> Gerd
next prev parent reply other threads:[~2010-08-26 12:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 14:19 [Qemu-devel] [PATCH v3 00/10] initial spice support Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 01/10] Use display types for local display only Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 02/10] Use machine_init() to register virtfs config options Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 03/10] add pflib: PixelFormat conversion library Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 04/10] configure: add logging Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 05/10] add spice into the configure file Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 06/10] spice: core bits Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 07/10] spice: add keyboard Gerd Hoffmann
2010-08-25 19:53 ` Anthony Liguori
2010-08-26 6:55 ` Gerd Hoffmann
2010-08-26 12:55 ` Anthony Liguori [this message]
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 08/10] spice: add mouse Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 09/10] spice: simple display Gerd Hoffmann
2010-08-25 19:57 ` Anthony Liguori
2010-08-26 6:56 ` Gerd Hoffmann
2010-08-25 14:19 ` [Qemu-devel] [PATCH v3 10/10] spice: add tablet support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C766456.3050408@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).