From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50484 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OocRA-00067w-52 for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:24:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OocIx-00013m-K9 for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:15:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16060) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OocIx-00013F-CZ for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:15:43 -0400 Message-ID: <4C7668FA.5080301@redhat.com> Date: Thu, 26 Aug 2010 16:15:38 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices References: <20100803161914.15514.59304.stgit@localhost6.localdomain6> <1282308092.3860.0.camel@x201> <4C6EA5C9.8080700@codemonkey.ws> <20100825030752.GA14605@valinux.co.jp> <4C7512BF.9000805@codemonkey.ws> In-Reply-To: <4C7512BF.9000805@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Isaku Yamahata , Alex Williamson , glommer@redhat.com, Markus Armbruster On 08/25/2010 03:55 PM, Anthony Liguori wrote: > >> Maybe we can merge the patches. >> As for your patch, I have some comment. >> - bus itself may want its own handler. At lease pci bus needs it. >> And propagating reset signal to children is up to the bus controller. > > I disagree. Reset should be equivalent to power off + init and it's > not something that can be selectively propagated. Not all busses propagate reset - SCSI is an example (I think). -- error compiling committee.c: too many arguments to function