qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>,
	Alex Williamson <alex.williamson@redhat.com>,
	glommer@redhat.com, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices
Date: Thu, 26 Aug 2010 08:25:36 -0500	[thread overview]
Message-ID: <4C766B50.50907@codemonkey.ws> (raw)
In-Reply-To: <4C7668FA.5080301@redhat.com>

On 08/26/2010 08:15 AM, Avi Kivity wrote:
>  On 08/25/2010 03:55 PM, Anthony Liguori wrote:
>>
>>> Maybe we can merge the patches.
>>> As for your patch, I have some comment.
>>> - bus itself may want its own handler. At lease pci bus needs it.
>>>    And propagating reset signal to children is up to the bus 
>>> controller.
>>
>> I disagree.  Reset should be equivalent to power off + init and it's 
>> not something that can be selectively propagated.
>
> Not all busses propagate reset - SCSI is an example (I think).
>

We're talking about cold reset vs. warm reset.

In the absence of passthrough, I'm struggling to see a useful use-case 
with warm reset.  However, there are many useful things we can do 
assuming a cold reset (like MADV_DONTNEED memory on reboot).

That's not saying we shouldn't do a warm reset, but I'd like to see that 
as an incremental addition to what we have today (like introducing a 
propagating warm reset callback) and thinking through what the actual 
behavior should and shouldn't be.

Regards,

Anthony Liguori

  reply	other threads:[~2010-08-26 13:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 16:19 [Qemu-devel] [PATCH] qdev: Reset hotplugged devices Alex Williamson
2010-08-03 17:41 ` [Qemu-devel] " Glauber Costa
2010-08-20  9:00 ` [Qemu-devel] " Markus Armbruster
2010-08-20 12:41   ` Alex Williamson
2010-08-20 15:47     ` Markus Armbruster
2010-08-20 15:56       ` Anthony Liguori
2010-08-20 16:14         ` Markus Armbruster
2010-08-20 18:12           ` Anthony Liguori
2010-08-20 22:05             ` Alex Williamson
2010-08-21 10:07             ` Markus Armbruster
2010-08-21 15:19               ` Anthony Liguori
2010-08-23 11:25             ` [Qemu-devel] " Paolo Bonzini
2010-08-23 13:27               ` Anthony Liguori
2010-08-25  3:07         ` [Qemu-devel] " Isaku Yamahata
2010-08-25 12:55           ` Anthony Liguori
2010-08-25 15:17             ` Isaku Yamahata
2010-08-25 16:49               ` Anthony Liguori
2010-08-26  8:38                 ` Isaku Yamahata
2010-08-26 13:02                   ` Anthony Liguori
2010-08-27  3:52                     ` Isaku Yamahata
2010-08-27 17:43                       ` Wei Xu
2010-08-27  7:28                     ` Isaku Yamahata
2010-08-26 13:04                   ` Anthony Liguori
2010-08-26 13:15             ` Avi Kivity
2010-08-26 13:25               ` Anthony Liguori [this message]
2010-08-26 14:29                 ` Avi Kivity
2010-08-26 17:39                   ` Blue Swirl
2010-08-23 12:00   ` Avi Kivity
2010-08-23 12:21     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C766B50.50907@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).