From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OocXI-0000rW-Sz for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:30:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OocXH-0003wQ-MD for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:30:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32626) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OocXH-0003wG-G1 for qemu-devel@nongnu.org; Thu, 26 Aug 2010 09:30:31 -0400 Message-ID: <4C766C67.7030506@redhat.com> Date: Thu, 26 Aug 2010 15:30:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped References: <8450ea8e785c9049f0b3edddc01650a8c4b9ffe7.1282265244.git.amit.shah@redhat.com> <4C719C7E.6030606@codemonkey.ws> <20100826060513.GF18351@amit-laptop.redhat.com> <4C762058.8070301@redhat.com> <20100826081750.GK18351@amit-laptop.redhat.com> <20100826082842.GE9564@redhat.com> <20100826095748.7e0b12ad@doriath> In-Reply-To: <20100826095748.7e0b12ad@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Amit Shah , agl@us.ibm.com, qemu list , Juan Quintela On 08/26/2010 02:57 PM, Luiz Capitulino wrote: > I really don't know what to do 0.13. Probably the hard-coded timer is > the best solution we have, but I'm wondering if it's going to cause > problems in the near future, when we get proper asynchronous command > support. Just make it a different command, or make it dependent on whether the initial handshaking activated the asynchronous command capability. Paolo