From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54007 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oohik-0003Iu-4p
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 15:02:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OohhO-0001wZ-3a
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 15:01:19 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:62457)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OohhN-0001wR-Qc
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 15:01:17 -0400
Received: by qyk5 with SMTP id 5so6668010qyk.4
	for <qemu-devel@nongnu.org>; Thu, 26 Aug 2010 12:01:17 -0700 (PDT)
Message-ID: <4C76B9F9.2040808@codemonkey.ws>
Date: Thu, 26 Aug 2010 14:01:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] vhost_net.c broken by --kerneldir
References: <4C746A1E.6070000@mentor.com>
	<201008251537.27679.arnd@arndb.de>	<4C755165.4040804@mentor.com>
	<201008261715.36022.arnd@arndb.de>
	<20100826152142.GV10499@redhat.com>
	<4C768CE3.2070304@codemonkey.ws> <4C76992B.4030902@mentor.com>
In-Reply-To: <4C76992B.4030902@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hollis Blanchard <hollis_blanchard@mentor.com>
Cc: mst@redhat.com, Arnd Bergmann <arnd@arndb.de>, Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org

On 08/26/2010 11:41 AM, Hollis Blanchard wrote:
> On 08/26/2010 08:48 AM, Anthony Liguori wrote:
>> On 08/26/2010 10:21 AM, Gleb Natapov wrote:
>>> You forgot about developers. Developer may want to use latest kvm 
>>> kernel
>>> headers to compile code that he added to qemu to use new kernel 
>>> feature.
>>
>> The Right Way to do this is a make headers_install to a temporary 
>> directory and then -I include that directory.  Building directly from 
>> the kernel source tree was never the right thing to do.
>
> Thanks, this worked well.
>
> What are your thoughts on renaming the configure option to 
> --kernel-headers?
>
>   --kerneldir=PATH         look for kernel includes in PATH

That's fine but FWIW, --kerneldir was intended to work with a kernel 
source tree.  It's just that that's become impossible in recent kernels.

Regards,

Anthon Liguori

> Hollis Blanchard
> Mentor Graphics, Embedded Systems Division
>