From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54176 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OokSq-0003F8-Up
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 17:58:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OokSQ-00027W-0z
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 17:58:02 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:43041)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OokSP-00027M-Tk
	for qemu-devel@nongnu.org; Thu, 26 Aug 2010 17:58:01 -0400
Received: by qyk31 with SMTP id 31so2297176qyk.4
	for <qemu-devel@nongnu.org>; Thu, 26 Aug 2010 14:58:01 -0700 (PDT)
Message-ID: <4C76E367.6050100@codemonkey.ws>
Date: Thu, 26 Aug 2010 16:57:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough
	interface
References: <1282753982-1761-1-git-send-email-andreas.niederl@iaik.tugraz.at>	<AANLkTikk7R36FgS53_8TSo6ouZ4T9BJd4=5oZqb3O4-7@mail.gmail.com>	<alpine.LNX.2.00.1008260041320.1964@linmac>	<AANLkTi=LCYcca2QzUDA631gGHSH3FOreHDRmU6C3mrRL@mail.gmail.com>
	<alpine.LNX.2.00.1008270137470.1495@linmac>
In-Reply-To: <alpine.LNX.2.00.1008270137470.1495@linmac>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>, Andreas Niederl <andreas.niederl@iaik.tugraz.at>, qemu-devel@nongnu.org

On 08/26/2010 04:44 PM, malc wrote:
>>      
>>> and lastly there is no errx[1]
>>>
>>> [..snip..]
>>>
>>> [1] err(3):
>>>     CONFORMING TO
>>>        These functions are non-standard BSD extensions.
>>>        
>> err() and errx() are already used somewhere. But these should be
>> converted to error_report etc., like other printf based local
>> functions.
>>
>>      
> Only in Linux specific nbd code.
>    

And the nbd stuff is derived from non-QEMU code that was brought into 
the tree.  It's generally a bad example of QEMU coding style.

Regards,

Anthony Liguori