From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59879 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OoyDZ-0004C8-HY for qemu-devel@nongnu.org; Fri, 27 Aug 2010 08:39:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OoyDU-0005tS-IA for qemu-devel@nongnu.org; Fri, 27 Aug 2010 08:39:37 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:34485) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoyDU-0005tI-Fx for qemu-devel@nongnu.org; Fri, 27 Aug 2010 08:39:32 -0400 Received: by qyk31 with SMTP id 31so2917872qyk.4 for ; Fri, 27 Aug 2010 05:39:31 -0700 (PDT) Message-ID: <4C77B209.6050902@codemonkey.ws> Date: Fri, 27 Aug 2010 07:39:37 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <51ec99ce2db02aeb34ec6683a76895b4a127057d.1282886503.git.amit.shah@redhat.com> <20100827092945.GC22361@redhat.com> In-Reply-To: <20100827092945.GC22361@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Amit Shah , Paolo Bonzini , agl@us.ibm.com, qemu list , Luiz Capitulino On 08/27/2010 04:29 AM, Daniel P. Berrange wrote: > On Fri, Aug 27, 2010 at 10:57:10AM +0530, Amit Shah wrote: > >> This error message denotes some command was not successful in completing >> as the guest was unresponsive. >> >> Use it in the virtio-balloon code when showing older, cached data. >> >> Signed-off-by: Amit Shah >> --- >> hw/virtio-balloon.c | 1 + >> qerror.c | 4 ++++ >> qerror.h | 3 +++ >> 3 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c >> index d6c66cf..309c343 100644 >> --- a/hw/virtio-balloon.c >> +++ b/hw/virtio-balloon.c >> @@ -140,6 +140,7 @@ static void complete_stats_request(VirtIOBalloon *vb) >> >> static void show_old_stats(void *opaque) >> { >> + qerror_report(QERR_MACHINE_STOPPED); >> complete_stats_request(opaque); >> } >> > > NACK. It has always been allowed& valid to call query-balloon > to get the current balloon level. We must not throw an error > just because the recently added mem stats can't be refreshed. > I think that's a fair comment but why even bother fixing the command. Let's introduce a new command that just gets a single piece of information instead of having a command return lots of information. Regards, Anthony Liguori > Regards, > Daniel >