From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42026 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Opdko-0000YD-2x
	for qemu-devel@nongnu.org; Sun, 29 Aug 2010 05:00:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Opdkm-0004Wu-NY
	for qemu-devel@nongnu.org; Sun, 29 Aug 2010 05:00:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37983)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1Opdkm-0004Wi-Fr
	for qemu-devel@nongnu.org; Sun, 29 Aug 2010 05:00:40 -0400
Message-ID: <4C7A21AC.4070804@redhat.com>
Date: Sun, 29 Aug 2010 12:00:28 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] QEMUFileBuffered: indicate that we're ready
	when the underlying file is ready
References: <1278521062-13795-1-git-send-email-avi@redhat.com>
	<4C6D4B8F.7080108@codemonkey.ws>
In-Reply-To: <4C6D4B8F.7080108@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

  On 08/19/2010 06:19 PM, Anthony Liguori wrote:
> On 07/07/2010 11:44 AM, Avi Kivity wrote:
>> QEMUFileBuffered stops writing when the underlying QEMUFile is not 
>> ready,
>> and tells its producer so.  However, when the underlying QEMUFile 
>> becomes
>> ready, it neglects to pass that information along, resulting in stoppage
>> of all data until the next tick (a tenths of a second).
>>
>> Usually this doesn't matter, because most QEMUFiles used with 
>> QEMUFileBuffered
>> are almost always ready, but in the case of exec: migration this is 
>> not true,
>> due to the small pipe buffers used to connect to the target process.  
>> The
>> result is very slow migration.
>>
>> Fix by detecting the readiness notification and propagating it.  The 
>> detection
>> is a little ugly since QEMUFile overloads put_buffer() to send it, 
>> but that's
>> the suject for a different patch.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>\
>
> Applied.  Thanks.

Should be applied to stable-0.13 as well.

-- 
error compiling committee.c: too many arguments to function