From: Paolo Bonzini <pbonzini@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: blauwirbel@gmail.com, glommer@redhat.com,
alex.williamson@redhat.com, qemu-devel@nongnu.org,
avi@redhat.com
Subject: [Qemu-devel] Re: [PATCH 5/5] RFC: distinguish warm reset from cold reset.
Date: Mon, 30 Aug 2010 10:50:47 +0200 [thread overview]
Message-ID: <4C7B70E7.80906@redhat.com> (raw)
In-Reply-To: <0a460e01cca4fa24f446c7a715fe6df17d0be9ed.1283152674.git.yamahata@valinux.co.jp>
On 08/30/2010 09:49 AM, Isaku Yamahata wrote:
> +/* those two functions are obsoleted by cold/warm reset API. */
> [qemu_register_reset/qemu_unregister_reset]
Are they?
They have a _lot_ of callers and most of the time you do not really care
about cold vs. warm reset. So, I think either you define a new API
where you can request cold reset/warm reset/both, or qemu_register_reset
is here to stay forever.
In general, I don't like the duplication you introduce between cold
reset, warm reset, shutdown, powerdown, etc. Maybe you can introduce a
new "VMEvent" abstraction with functions like "request", "is requested",
"register handler"?
It could also be interesting to convert everything to the Notifier API,
if someone wants to play with Coccinelle...
Paolo
next prev parent reply other threads:[~2010-08-30 11:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:49 [Qemu-devel] [PATCH 0/5] RFC: distinguish warm reset from cold reset Isaku Yamahata
2010-08-30 7:49 ` [Qemu-devel] [PATCH 1/5] sysemu.h, vl.c: static'fy qemu_xxx_requested() Isaku Yamahata
2010-08-30 7:49 ` [Qemu-devel] [PATCH 2/5] vl.c: consolidate qemu_xxx_requested() logic Isaku Yamahata
2010-08-30 7:49 ` [Qemu-devel] [PATCH 3/5] vl.c: consolidate qemu_system_xxx_request() logic Isaku Yamahata
2010-08-30 7:49 ` [Qemu-devel] [PATCH 4/5] vl.c: factor out qemu_reguster/unregister_reset() Isaku Yamahata
2010-08-30 7:49 ` [Qemu-devel] [PATCH 5/5] RFC: distinguish warm reset from cold reset Isaku Yamahata
2010-08-30 8:50 ` Paolo Bonzini [this message]
2010-08-30 9:38 ` [Qemu-devel] " Isaku Yamahata
2010-08-30 9:31 ` Paolo Bonzini
2010-08-30 13:03 ` Anthony Liguori
2010-08-30 19:16 ` Blue Swirl
2010-08-30 19:25 ` Anthony Liguori
2010-08-30 19:36 ` Blue Swirl
2010-08-30 20:10 ` Anthony Liguori
2010-08-30 12:59 ` Anthony Liguori
2010-08-31 2:58 ` Isaku Yamahata
2010-08-31 13:08 ` Anthony Liguori
2010-08-31 13:14 ` Gleb Natapov
2010-08-31 13:20 ` Anthony Liguori
2010-08-31 13:21 ` Gleb Natapov
2010-08-31 13:26 ` Anthony Liguori
2010-08-31 13:29 ` Avi Kivity
2010-08-31 13:34 ` Anthony Liguori
2010-08-31 13:46 ` Avi Kivity
2010-08-31 13:58 ` Anthony Liguori
2010-08-31 14:03 ` Gleb Natapov
2010-08-31 14:03 ` Avi Kivity
2010-08-31 15:00 ` Anthony Liguori
2010-08-31 16:04 ` Avi Kivity
2010-08-31 13:35 ` Gleb Natapov
2010-08-30 7:59 ` [Qemu-devel] Re: [PATCH 0/5] " Avi Kivity
2010-08-30 8:35 ` Isaku Yamahata
2010-08-30 11:19 ` Gleb Natapov
2010-08-30 13:05 ` Anthony Liguori
2010-08-30 13:15 ` Gleb Natapov
2010-08-30 19:07 ` Blue Swirl
2010-08-31 5:26 ` Gleb Natapov
2010-08-30 13:04 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7B70E7.80906@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).