From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42767 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oq486-0004PD-9J
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:10:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oq484-0000w9-Vj
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:10:29 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:47544)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oq484-0000w4-S9
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:10:28 -0400
Received: by gxk26 with SMTP id 26so2318286gxk.4
	for <qemu-devel@nongnu.org>; Mon, 30 Aug 2010 06:10:28 -0700 (PDT)
Message-ID: <4C7BACC4.2030603@codemonkey.ws>
Date: Mon, 30 Aug 2010 08:06:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED
	error message
References: <cover.1282886503.git.amit.shah@redhat.com>	<51ec99ce2db02aeb34ec6683a76895b4a127057d.1282886503.git.amit.shah@redhat.com>	<20100827092945.GC22361@redhat.com>
	<4C77B209.6050902@codemonkey.ws>	<20100828005243.GB415@amit-laptop.redhat.com>
	<m3hbiccxkd.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3hbiccxkd.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu list <qemu-devel@nongnu.org>, agl@us.ibm.com

On 08/30/2010 03:30 AM, Markus Armbruster wrote:
> Amit Shah<amit.shah@redhat.com>  writes:
>
>    
>> On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
>>      
>>>> NACK. It has always been allowed&   valid to call query-balloon
>>>> to get the current balloon level. We must not throw an error
>>>> just because the recently added mem stats can't be refreshed.
>>>>          
>>> I think that's a fair comment but why even bother fixing the
>>> command.  Let's introduce a new command that just gets a single
>>> piece of information instead of having a command return lots of
>>> information.
>>>        
>> Instead, let's have query-balloon do the same thing as it did in 0.12
>> and add a new command for 0.13 (query-balloon-stats) that does the stats
>> with timeout?
>>
>> That way we won't have regressions from 0.12 and have the new behaviour
>> only for 0.13, which we can say is 'experimental'.
>>      
> Sounds sensible to me.  Not too late for fixing 0.13?  Anthony?
>    

No new commands for 0.13.  I think the only option is to revert the 
query-balloon behavior.  A new command is too risky as -rc1 is imminent.

Regards,

Anthony Liguori