From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34241 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq4Dm-0007Q5-6S for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:16:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq4DS-00020a-GB for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:16:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40641) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq4DS-00020O-7u for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:16:02 -0400 Message-ID: <4C7BAF1A.3040509@redhat.com> Date: Mon, 30 Aug 2010 15:16:10 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] fix scsi-generic References: <4C5EACF8.1010101@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: adq Cc: qemu-devel@nongnu.org Am 08.08.2010 22:08, schrieb adq: > On 8 August 2010 14:11, Kevin Wolf wrote: >> Am 07.08.2010 02:55, schrieb adq: >>> Hi, I've been tracking down why scsi generic devices (using SG_IO) >>> don't work any more. After adding debug, I can see that it actually >>> submits the scsi CDB in hw/scsi-generic.c/execute_command(), but that >>> the hw/scsi-generic.c/scsi_read_complete() callback is never called. >>> >>> This is because these are done with ioctls, and the posix async ioctl >>> code is, I think, broken right now. Some more debugging, led me to >>> posix-aio-compat.c/posix_aio_process_queue(): >>> >>> if (acb->async_context_id != async_context_id) { >>> >>> The async_context_ids don't match, so the request is never handled. >>> This is because the acb->async_context_id field is not initialised in >>> posix-aio-compat.c/paio_ioctl() (compare with >>> posix-aio-compat.c/paio_submit()). The attached patch adds the missing >>> line in. >>> >>> This seems to fix the problem. Of course, /now/ I'm getting other >>> weird problems (as I'm trying to see if I can get slysoft anydvd >>> working in a KVM winXP vm), but they need further investigation and >>> likely other fixes. >>> >>> Please forgive me if I'm mistaken in this, I've only just started >>> looking at the qemu code. >> >> The patch looks correct to me. >> >> Please use git format-patch to generate the patch, so that it contains a >> decent commit message and I can apply it with git am. Also, please don't >> forget the Signed-off-by line, otherwise we can't accept it. > > Hi, please find it attached; I've not used format-patch before, hope > this is correct! Thanks, applied to the block branch. And sorry for the delay. Kevin