From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44120 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq4ri-0005L8-4i for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:57:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq4rf-0001VK-Oh for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28046) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq4rf-0001VD-IR for qemu-devel@nongnu.org; Mon, 30 Aug 2010 09:57:35 -0400 Message-ID: <4C7BB8CB.6020909@redhat.com> Date: Mon, 30 Aug 2010 15:57:31 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1283156160-4278-1-git-send-email-Jes.Sorensen@redhat.com> <4C7BAB85.10604@codemonkey.ws> <4C7BAE1C.2070007@redhat.com> <4C7BB5F7.6010906@codemonkey.ws> In-Reply-To: <4C7BB5F7.6010906@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jes Sorensen , qemu-devel@nongnu.org On 08/30/10 15:45, Anthony Liguori wrote: > On 08/30/2010 08:11 AM, Jes Sorensen wrote: >> On 08/30/10 15:00, Anthony Liguori wrote: >>> On 08/30/2010 03:16 AM, Jes.Sorensen@redhat.com wrote: >>>> From: Jes Sorensen >>>> >>>> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is >>>> setup >>>> at init time, it is not possible to load an option ROM for a hotplug >>>> device when running in compat mode. >>>> >>>> v2: Alex Williamson pointed out that one can get to qdev directly from >>>> pci_dev, so no need to pass it down. >>>> >>>> v3: Braces >>>> >>> What's the specific bug? The devices themselves have a check for >>> hotplug which inhibits rom addition during hotplug so either there's a >>> device missing this check or if we're going to go this route, we ought >>> to remove those checks in the other devices. >> If you run in -M pc-0.11 or older option ROMs are provided via fw_cfg, >> which means QEMU is unable to load it after boot time if you try to >> hot-plug a new network device via the monitor. Instead it decides to >> exit with an error. > > Which network device? > > Take a look at ne2k.c's rom loading. It's got logic for rom loading with > hotplug but e1000 and rtl8139 don't. Maybe it's because ne2k also > supports an ISA mode? I think I just forgot to convert ne2k over to using .romfile instead. Just skipping fw_cfg-based rom loading looks sane to me. After all it is just for pc-0.11 compatibility. And it is even bug compatible: hot-plug nic + reboot + pxe-boot from the hot-plugged nic didn't work in 0.11 too ;) cheers, Gerd