From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44486 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq4u5-0007LC-Au for qemu-devel@nongnu.org; Mon, 30 Aug 2010 10:00:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq4u3-0001vu-8U for qemu-devel@nongnu.org; Mon, 30 Aug 2010 10:00:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15043) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq4u2-0001vl-W2 for qemu-devel@nongnu.org; Mon, 30 Aug 2010 10:00:03 -0400 Message-ID: <4C7BB95F.8070509@redhat.com> Date: Mon, 30 Aug 2010 15:59:59 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1283156160-4278-1-git-send-email-Jes.Sorensen@redhat.com> <4C7BAB85.10604@codemonkey.ws> <4C7BAE1C.2070007@redhat.com> <4C7BB5F7.6010906@codemonkey.ws> In-Reply-To: <4C7BB5F7.6010906@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Gerd Hoffmann On 08/30/10 15:45, Anthony Liguori wrote: > On 08/30/2010 08:11 AM, Jes Sorensen wrote: >> If you run in -M pc-0.11 or older option ROMs are provided via fw_cfg, >> which means QEMU is unable to load it after boot time if you try to >> hot-plug a new network device via the monitor. Instead it decides to >> exit with an error. >> > > Which network device? > > Take a look at ne2k.c's rom loading. It's got logic for rom loading > with hotplug but e1000 and rtl8139 don't. Maybe it's because ne2k also > supports an ISA mode? It happens with virtio-net as well which is where I saw it first. However, it's really only an issue in compat mode since with 0.12 onwards we can load option ROMs on the fly. Cheers, Jes