From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40216 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oq7vY-0002da-KH
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 13:13:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oq7vX-0004ql-Ic
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 13:13:48 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:45672)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Oq7vX-0004qf-BR
	for qemu-devel@nongnu.org; Mon, 30 Aug 2010 13:13:47 -0400
Received: by qyk5 with SMTP id 5so3145111qyk.4
	for <qemu-devel@nongnu.org>; Mon, 30 Aug 2010 10:13:46 -0700 (PDT)
Message-ID: <4C7BE6C2.8040101@codemonkey.ws>
Date: Mon, 30 Aug 2010 12:13:38 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 11/14] Remove unused function arguments
References: <1283182547-26116-1-git-send-email-Jes.Sorensen@redhat.com>	<1283182547-26116-12-git-send-email-Jes.Sorensen@redhat.com>
	<4C7BDB54.60008@redhat.com>
In-Reply-To: <4C7BDB54.60008@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org

On 08/30/2010 11:24 AM, Paolo Bonzini wrote:
> On 08/30/2010 05:35 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> I think it's better to leave ctxt in for future extensibility.
>
> You can mark it as __attribute__((unused)) to suppress the warning.

That seriously ugifies the code IMHO.

Regards,

Anthony Liguori

> Paolo
>