From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41580 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq95L-0003M6-Pb for qemu-devel@nongnu.org; Mon, 30 Aug 2010 14:28:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq95K-0000HJ-N2 for qemu-devel@nongnu.org; Mon, 30 Aug 2010 14:27:59 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:41731) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq95K-0000H8-L0 for qemu-devel@nongnu.org; Mon, 30 Aug 2010 14:27:58 -0400 Received: by qwh5 with SMTP id 5so5369926qwh.4 for ; Mon, 30 Aug 2010 11:27:58 -0700 (PDT) Message-ID: <4C7BF828.7060102@codemonkey.ws> Date: Mon, 30 Aug 2010 13:27:52 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1283183960-28404-1-git-send-email-Jes.Sorensen@redhat.com> <1283183960-28404-6-git-send-email-Jes.Sorensen@redhat.com> <4C7BD96E.3010500@codemonkey.ws> <4C7BDEF7.4070601@redhat.com> <4C7BF622.50706@redhat.com> In-Reply-To: <4C7BF622.50706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 05/14] Remove unused argument for check_for_block_signature() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org On 08/30/2010 01:19 PM, Jes Sorensen wrote: > > I totally agree on this. The problem with having such arguments passed > in is that you never know if they were used in the past and it was > forgotten when the code using them was removed, or if it's new code, in > which case they do deserve the extra scrutiny. > Or, we exercise common sense instead of blinding removing arguments just because a certain uncommon warning mode of GCC complains. Regards, Anthony Liguori > Cheers, > Jes >