From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49670 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq9d7-0003k6-Ds for qemu-devel@nongnu.org; Mon, 30 Aug 2010 15:02:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq9d4-00087K-5O for qemu-devel@nongnu.org; Mon, 30 Aug 2010 15:02:53 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:50867) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq9d4-000879-2f for qemu-devel@nongnu.org; Mon, 30 Aug 2010 15:02:50 -0400 Received: by qyk31 with SMTP id 31so5584200qyk.4 for ; Mon, 30 Aug 2010 12:02:49 -0700 (PDT) Message-ID: <4C7C0059.5040005@codemonkey.ws> Date: Mon, 30 Aug 2010 14:02:49 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v4 00/10] initial spice support. References: <1282903199-30669-1-git-send-email-kraxel@redhat.com> <4C7B705E.60404@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Gerd Hoffmann , qemu-devel@nongnu.org On 08/30/2010 01:58 PM, Blue Swirl wrote: > > Wilful misconduct? May I ask if there are other things that you don't > agree with and you are covertly working against? > :-) Braces should be used. The discussion was about enforcing coding style at commit time and reformatting code. But for the most part, people agree that we want braces to be used on single line ifs. Regards, Anthony Liguori