From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.
Date: Mon, 30 Aug 2010 21:32:16 +0200 [thread overview]
Message-ID: <4C7C0740.8010707@redhat.com> (raw)
In-Reply-To: <4C7C0059.5040005@codemonkey.ws>
On 08/30/10 21:02, Anthony Liguori wrote:
> On 08/30/2010 01:58 PM, Blue Swirl wrote:
>>
>> Wilful misconduct? May I ask if there are other things that you don't
>> agree with and you are covertly working against?
I'm just not used to it. Changing habits takes time.
I think I became better meanwhile on avoiding "if (NULL == ptr)" ;)
> Braces should be used. The discussion was about enforcing coding style
> at commit time and reformatting code.
The discussion started with unhappiness about the current situation
(code not matching code style being committed). I've seen messages
discussing whenever we should change code style or commit policy. I
qickly stopped following the huge thread though, thats why I ask.
> But for the most part, people agree that we want braces to be used on
> single line ifs.
Ok, so code style stays as-is. Anyone has a code style git commit hook
ready for me? So I can let git do the style review and I don't waste
everybody's time with that boring stuff?
thanks,
Gerd
next prev parent reply other threads:[~2010-08-30 19:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 9:59 [Qemu-devel] [PATCH v4 00/10] initial spice support Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 01/10] Use display types for local display only Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 02/10] Use machine_init() to register virtfs config options Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 03/10] add pflib: PixelFormat conversion library Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 04/10] configure: add logging Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 05/10] add spice into the configure file Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 06/10] spice: core bits Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 07/10] spice: add keyboard Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 08/10] spice: add mouse Gerd Hoffmann
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 09/10] spice: simple display Gerd Hoffmann
2010-08-27 12:42 ` Anthony Liguori
2010-08-27 9:59 ` [Qemu-devel] [PATCH v4 10/10] spice: add tablet support Gerd Hoffmann
2010-08-28 6:42 ` [Qemu-devel] [PATCH v4 00/10] initial spice support Blue Swirl
2010-08-30 8:48 ` Gerd Hoffmann
2010-08-30 18:58 ` Blue Swirl
2010-08-30 19:02 ` Anthony Liguori
2010-08-30 19:32 ` Gerd Hoffmann [this message]
2010-08-30 19:45 ` Blue Swirl
2010-08-31 9:54 ` Gerd Hoffmann
2010-08-31 13:09 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7C0740.8010707@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).