From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kwolf@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 05/14] Remove unused argument for check_for_block_signature()
Date: Tue, 31 Aug 2010 09:13:58 +0200 [thread overview]
Message-ID: <4C7CABB6.8090800@redhat.com> (raw)
In-Reply-To: <4C7BF828.7060102@codemonkey.ws>
On 08/30/10 20:27, Anthony Liguori wrote:
> On 08/30/2010 01:19 PM, Jes Sorensen wrote:
>>
>> I totally agree on this. The problem with having such arguments passed
>> in is that you never know if they were used in the past and it was
>> forgotten when the code using them was removed, or if it's new code, in
>> which case they do deserve the extra scrutiny.
>>
>
> Or, we exercise common sense instead of blinding removing arguments just
> because a certain uncommon warning mode of GCC complains.
Before making the change, I did indeed look at the code for a while,
considering whether it was reasonable to leave the unused variable in
place. However I don't see anything in there that makes it likely that
the block state parameter is going to be used in that function in the
near future, if at all.
If you feel so strongly about it, then lets apply the __unused attribute
as Richard suggested so it's clear that that argument was added on purpose.
Jes
next prev parent reply other threads:[~2010-08-31 7:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 15:59 [Qemu-devel] [PATCH 00/14] gcc extra warning fixes v2 Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 01/14] Remove unused argument for nbd_client() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 02/14] Respect return value from nbd_client() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 03/14] Fix repeated typo: was "end if list" instead of "end of list" Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 04/14] Zero initialize timespec struct explicitly Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 05/14] Remove unused argument for check_for_block_signature() Jes.Sorensen
2010-08-30 16:16 ` [Qemu-devel] " Anthony Liguori
2010-08-30 16:40 ` Paolo Bonzini
2010-08-30 18:19 ` Jes Sorensen
2010-08-30 18:27 ` Anthony Liguori
2010-08-30 19:24 ` Richard Henderson
2010-08-31 7:13 ` Jes Sorensen [this message]
2010-08-30 15:59 ` [Qemu-devel] [PATCH 06/14] Remove unused argument for encrypt_sectors() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 07/14] Remove unused argument for get_whole_cluster() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 08/14] Remove unused argument for qcow2_encrypt_sectors() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 09/14] Remove unused arguments for add_aio_request() and free_aio_req() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 11/14] Remove unused function arguments Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 12/14] size_t is unsigned, change to ssize_t to handle errors from tight_compress_data() Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 13/14] Change DPRINTF() to do{}while(0) to avoid compiler warning Jes.Sorensen
2010-08-30 15:59 ` [Qemu-devel] [PATCH 14/14] load_multiboot(): get_image_size() returns int Jes.Sorensen
2010-08-31 7:48 ` [Qemu-devel] Re: [PATCH 00/14] gcc extra warning fixes v2 Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7CABB6.8090800@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).