From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51714 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqLaF-00059i-DW for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqLaE-0006FF-Dc for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:48:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2269) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqLaE-0006Et-6i for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:48:42 -0400 Message-ID: <4C7CB3E1.9050605@redhat.com> Date: Tue, 31 Aug 2010 09:48:49 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1283183960-28404-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1283183960-28404-1-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 00/14] gcc extra warning fixes v2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org Am 30.08.2010 17:59, schrieb Jes.Sorensen@redhat.com: > From: Jes Sorensen > > Hi, > > I started building QEMU with some more aggressive error flags to see > what dropped out. I started fixing up some of the cases, removing > unused arguments to functions, comparisons of unsigned types against > negative values etc. and a few other minor changes to avoid compiler > warnings. > > v2 fixes the vnc change as pointed out by Anthony. > > Set of 14 patches following. > > Cheers, > Jes > > Jes Sorensen (14): > Remove unused argument for nbd_client() > Respect return value from nbd_client() > Fix repeated typo: was "end if list" instead of "end of list" > Zero initialize timespec struct explicitly > Remove unused argument for check_for_block_signature() > Remove unused argument for encrypt_sectors() > Remove unused argument for get_whole_cluster() > Remove unused argument for qcow2_encrypt_sectors() > Remove unused arguments for add_aio_request() and free_aio_req() > Zero json struct with memset() instea of = {} to keep compiler happy. > Remove unused function arguments > size_t is unsigned, change to ssize_t to handle errors from > tight_compress_data() > Change DPRINTF() to do{}while(0) to avoid compiler warning > load_multiboot(): get_image_size() returns int For the block related ones: Acked-by: Kevin Wolf